Lumino adv tree #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is saved along with the Lumino layout for restoring after navigation. Implemented for the log view only so far.
MetRonnie
reviewed
Mar 7, 2024
src/views/Log.vue
Outdated
| if (!taskTokens?.task) { | ||
| if (!taskTokens || !taskTokens.task) { |
src/views/Tree.vue
Outdated
Comment on lines
227
to
231
| /** | ||
| * The selection expand/collapse option. | ||
| * @type {import('vue').Ref<string>} | ||
| */ | ||
| const expandAll = useInitialOptions('expandAll', { props, emit }, ref(null)) |
There was a problem hiding this comment.
I don't think it makes sense to store this, as this is not really a setting but a trigger. For example, a user could click collapse all, then expand a selection of nodes. If they navigated away then back, they would find all nodes collapsed again. We don't currently have a way to store the expanded/collapsed state of every node in the tree as a whole.
Suggested change
| /** | |
| * The selection expand/collapse option. | |
| * @type {import('vue').Ref<string>} | |
| */ | |
| const expandAll = useInitialOptions('expandAll', { props, emit }, ref(null)) | |
| /** | |
| * Setting this to an empty array causes all nodes to collapse. | |
| * Setting it to an array of node types causes those node types to expand. | |
| * @type {import('vue').Ref<string[]|null>} | |
| */ | |
| const expandAll = ref(null) |
src/views/Tree.vue
Outdated
|
|
||
| /** | ||
| * The job id input and selected task filter state. | ||
| * @type {import('vue').Ref<string>} |
There was a problem hiding this comment.
Suggested change
| * @type {import('vue').Ref<string>} | |
| * @type {import('vue').Ref<Object>} |
|
This branch has been merged so now need to open a PR against master. Can you rebase onto master & squash the commits down before opening the PR please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes build on the work undertaken to save & restore workspace layout on navigation cylc#1664
Which is part of a larger issue cylc#662
There is an equivalent pull request for the tree view cylc#1688
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.